Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade v1.0 cache items #454

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Upgrade v1.0 cache items #454

merged 2 commits into from
Sep 6, 2023

Conversation

chlowell
Copy link
Collaborator

@chlowell chlowell commented Sep 1, 2023

This implements an algorithm for gradually weeding v1.0 keys out of a persistent cache to prevent authentication loops due to stale data (fixes #453; see that issue for more details). When a cache item matches search criteria, the storage manager will check whether its key follows the v1.0 schema. If it does, the manager will replace the item with one having the same data but a v1.1+ key.

I didn't make similar changes to the partitioned storage manager (used only for OBO) because it can't unmarshal data (#455). That means it can only write to a persistent cache, not read from one, so I doubt anyone has a partitioned cache to upgrade.

@chlowell chlowell marked this pull request as ready for review September 5, 2023 23:08
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chlowell chlowell added the bug Something isn't working label Sep 6, 2023
@chlowell chlowell merged commit c3591af into main Sep 6, 2023
9 checks passed
@chlowell chlowell deleted the chlowell/cache-upgrade branch September 6, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] msal cache incompatiblity between v1.0 and v1.1
3 participants