Upgrade v1.0 cache items #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
approved these changes
Sep 6, 2023
jhendrixMSFT
approved these changes
Sep 6, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements an algorithm for gradually weeding v1.0 keys out of a persistent cache to prevent authentication loops due to stale data (fixes #453; see that issue for more details). When a cache item matches search criteria, the storage manager will check whether its key follows the v1.0 schema. If it does, the manager will replace the item with one having the same data but a v1.1+ key.
I didn't make similar changes to the partitioned storage manager (used only for OBO) because it can't unmarshal data (#455). That means it can only write to a persistent cache, not read from one, so I doubt anyone has a partitioned cache to upgrade.