Use SHA256 thumbprints in non-ADFS cert flows #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Jul 14, 2024
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ClientCertificate.java
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 14, 2024
| @@ -160,7 +160,7 @@ private ClientAssertion getClientAssertion(String clientId) { | |||
| clientId, | |||
| (ClientCertificate) certificate, | |||
| "https://login.microsoftonline.com/common/oauth2/v2.0/token", | |||
| true); | |||
| true, false); | |||
There was a problem hiding this comment.
Am I correct in understanding that the existing tests cover the following?
- AAD + sha2
- ADFS + sha1
bgavrilMS
approved these changes
Jul 14, 2024
…tion-library-for-java into avdunn/update-sha-method
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the internal thumbprint method for certificate flows from SHA-1 to SHA-256, as per #760
ADFS scenarios must still use SHA-1 until SHA-256 is supported server-side.