Add object ID option for Managed Identity #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localden
approved these changes
Aug 20, 2024
bgavrilMS
approved these changes
Aug 20, 2024
rayluo
approved these changes
Aug 20, 2024
g2vinay
reviewed
Aug 20, 2024
| LOG.info("[Managed Identity] Adding user assigned resource id to the request for Service Fabric Managed Identity."); | ||
| managedIdentityRequest.queryParameters.put(Constants.MANAGED_IDENTITY_RESOURCE_ID, Collections.singletonList(userAssignedId)); | ||
| if (this.idType != null && !StringHelper.isNullOrBlank(this.userAssignedId)) { | ||
| LOG.info("[Managed Identity] Adding user assigned ID to the request for Service Fabric Managed Identity."); |
There was a problem hiding this comment.
This does reduce the visibility in logs as to which user assigned is being used.
There was a problem hiding this comment.
Have a look at the changes in the ManagedIdentityRequest class: the new addUserAssignedIdToQuery method called right after this log has the same sort of "Adding [this type of ID] to the request" log message that these classes used to have.
You'll still get the same information about the MI source type and ID type being used, it's just that they will be in two info logs.
This was referenced Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for object IDs, as per #853. Object IDs will now be accepted in IMDS, App Service, and Service Fabric scenarios, matching the support in .NET
This PR also does some minor code cleanup (remove unused code, move common code to parent classes, etc.)