Track MSAL node SKU for broker flows #7213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
konstantin-msft
commented
Jul 19, 2024
konstantin-msft
commented
- Track MSAL node SKU for broker flows.
- Move SKU instrumentation to common
- Move SKU instrumentation to common
konstantin-msft
requested review from
sameerag,
tnorling,
hectormmg,
peterzenz,
bgavrilMS,
Robbie-Microsoft,
trwalke,
pmaytak,
gladjohn,
neha-bhargava,
rayluo,
Avery-Dunn and
jo-arroyo
as code owners
github-actions
bot
added
documentation
tnorling
approved these changes
Jul 19, 2024
| AADServerParamKeys.X_CLIENT_EXTRA_SKU, | ||
| ServerTelemetryManager.makeExtraSkuString({ | ||
| skus, | ||
| extensionName: "msal.node.ext", |
There was a problem hiding this comment.
Can we make this a constant?
There was a problem hiding this comment.
Unfortunately, we can't as skus is picked up from request.extraParameters.
There was a problem hiding this comment.
I was referring to msal.node.ext
peterzenz
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.