Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Microsoft.Identity.Abstractions should bring a net462 target framework #45

Closed
jmprieur opened this issue Dec 14, 2022 · 1 comment
Closed

[Feature Request] Microsoft.Identity.Abstractions should bring a net462 target framework #45

jmprieur opened this issue Dec 14, 2022 · 1 comment
Labels
bug Something isn't working fixed

Comments

@jmprieur
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When net462 libraries (think Id.Web, SAL) take a dependency on netstandard2.0 libraries, this ends-up pulling the whole framework, whereas Microsoft.Identity.Abstractions is tiny and does not reference much. By adding direct support for net462, this enables to draw less dependencies

Describe the solution you'd like
Add the net462 target framework

Describe alternatives you've considered
None

Additional context
See also the common dependency management.
@jmprieur jmprieur added the bug Something isn't working label Dec 14, 2022
jmprieur added a commit that referenced this issue Dec 29, 2022
@jmprieur
Fixes #48 and #45
ac722d3 
- Adds netstandard2.1 (because HttpMethod.Patch is widely used).
- Adds the Patch methods to IDownstreamRestApi
- and net462 (to avoid drawing the entiere framework when this
library is consumed from a library targeting 462)
- more test coverage.
@jmprieur jmprieur mentioned this issue Dec 29, 2022
Merged
jmprieur added a commit that referenced this issue Dec 29, 2022
@jmprieur
Jmprieur/add target462 (#49)
6971747 
* Fixes #48 and #45
- Adds netstandard2.1 (because HttpMethod.Patch is widely used).
- Adds the Patch methods to IDownstreamRestApi
- and net462 target (to avoid drawing the entire framework when this
library is consumed from a library targeting 462)
- more test coverage.
* Update dotnetcore.yml to run on windows (as we have a .NET FW target)
* Addressing PR feedback
@jmprieur jmprieur added the fixed label Dec 29, 2022
@jennyf19
Copy link
Collaborator

jennyf19 commented Jan 5, 2023

in 1.0.6-preview

@jennyf19 jennyf19 closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmprieur @jennyf19