Adding publicAPI, bannedApi, and Async analyzers #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
commented
Sep 17, 2024
| @@ -115,7 +115,7 @@ namespace Microsoft.Identity.Abstractions | |||
| /// </code> | |||
| /// </example> | |||
| <# if (framework != "net8"){ #> | |||
| #if NET6_0_OR_GREATER | |||
| #if NET8_0_OR_GREATER | |||
There was a problem hiding this comment.
We don't build for NET6.0 any longer.
Updating GiHub action Signed-off-by: Jean-Marc Prieur <jmprieur@microsoft.com>
Directory.Build.props
Outdated
| @@ -28,9 +28,17 @@ | |||
| <LangVersion>12</LangVersion> | |||
| <EnablePackageValidation>true</EnablePackageValidation> | |||
| <PackageValidationBaselineVersion>5.0.0</PackageValidationBaselineVersion> | |||
| </PropertyGroup> | |||
| <BannedApiAnalyzersVersion>3.3.4</BannedApiAnalyzersVersion> | |||
Directory.Build.props
Outdated
| @@ -39,7 +47,8 @@ | |||
| <!-- The MSAL.snk has both private and public keys --> | |||
| <DelaySign>false</DelaySign> | |||
| <EnableNETAnalyzers>true</EnableNETAnalyzers> | |||
| <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild> | |||
| <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild> | |||
There was a problem hiding this comment.
We can simplify a bit if we don't want to have opt outs. These can go, and the conditions in the item groups can go.
jennyf19
approved these changes
Sep 17, 2024
| </PropertyGroup> | ||
| <ItemGroup Label="Build Tools" | ||
| Condition="$([MSBuild]::IsOsPlatform('Windows'))"> | ||
| <PackageReference Include="Microsoft.SourceLink.GitHub" |
There was a problem hiding this comment.
FYI: https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/source-link
sourcelink is in the SDK in net 8 or greater
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding publicAPI, bannedApi, and Async analyzers
Before starting changes in the public API for the 1P extensibility