Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use oidc endpoint for issuer validation. #1241

Merged
merged 2 commits into from
Jun 7, 2021
Merged

use oidc endpoint for issuer validation. #1241

merged 2 commits into from
Jun 7, 2021

Conversation

jennyf19
Copy link
Collaborator

@jennyf19 jennyf19 commented Jun 4, 2021

#1167 + css related issue

@jennyf19 jennyf19 marked this pull request as ready for review June 5, 2021 21:56
@jennyf19 jennyf19 requested a review from jmprieur June 5, 2021 21:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

88.0% 88.0% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @jennyf19

It's a great simplification (and will be more resilient to clouds)

/// </summary>
/// <param name="aadAuthority">Aad authority.</param>
/// <returns>NotImplementedException.</returns>
[Obsolete(IDWebErrorMessage.AadIssuerValidatorGetIssuerValidatorIsObsolete, true)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's ok to remove this obsolete method.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can add it back if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants