split id web into smaller nuget packages (tokencache & certificate) #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymeskar
reviewed
Sep 10, 2021
src/Microsoft.Identity.TokenCache/Microsoft.Identity.TokenCache.csproj
Outdated
Show resolved
Hide resolved
rymeskar
reviewed
Sep 10, 2021
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'"> | ||
| <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="2.2.0" /> |
There was a problem hiding this comment.
The extensions.* versions should be IMHO aligned. Otherwise, right from start we force the clients to run in a non-tested setup. (ASP.)NET Core team always tests the assemblies with the same version cross-working.
|
SonarCloud Quality Gate failed. |
jmprieur
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1431