Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple UI merging branch #1468

Merged
merged 12 commits into from
Oct 4, 2021
Merged

Decouple UI merging branch #1468

merged 12 commits into from
Oct 4, 2021

Conversation

jennyf19
Copy link
Collaborator

@jennyf19 jennyf19 commented Oct 1, 2021

work from @Ponant

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jennyf19 jennyf19 marked this pull request as ready for review October 4, 2021 03:37
jmprieur
jmprieur approved these changes Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @jennyf19.

@jmprieur
Copy link
Collaborator

jmprieur commented Oct 4, 2021

and Thanks @Ponant !

@jennyf19 jennyf19 merged commit 52c4f8b into master Oct 4, 2021
@jennyf19 jennyf19 deleted the jennyf/ponantPR branch October 4, 2021 03:39
@Ponant Ponant mentioned this pull request Oct 6, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jennyf19 @jmprieur @Ponant