update Id web to support authentication handlers other than JwtBearer… #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and provide extension method
|
SonarCloud Quality Gate failed. |
GeoK
reviewed
Oct 22, 2021
| /// <summary> | ||
| /// Web API authentication builder. | ||
| /// </summary> | ||
| public static class WebApiBuildersInternal |
There was a problem hiding this comment.
nit: a bit odd to suffix a public class with 'Internal'. #Resolved
There was a problem hiding this comment.
we are trying to hide it. yes, it's odd.
There was a problem hiding this comment.
will go with WebApiBuilders but leave it in the internal namespace
GeoK
reviewed
Oct 22, 2021
| public static class WebApiBuildersInternal | ||
| { | ||
| /// <summary> | ||
| /// Enables token acquisition which is not specific to JWT, such as when using Microsoft.Identity.Service.Essentials (MISE). |
There was a problem hiding this comment.
Don't need to call-out MISE specifically. It now allows a higher level abstraction of security token (i.e. System.IdentityModel.Tokens.Jwt and more modern, Microsoft.IdentityModel.JsonWebTokens) to be used with IdWeb. #Resolved
There was a problem hiding this comment.
that's beautiful! well said!
|
Approving Wilson specific changes. |
GeoK
approved these changes
Oct 22, 2021
jmprieur
approved these changes
Oct 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and provide extension method
replaces #1493