Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to samples home page #153

Merged
merged 1 commit into from
May 11, 2020
Merged

Minor fixes to samples home page #153

merged 1 commit into from
May 11, 2020

Conversation

pmaytak
Copy link
Contributor

@pmaytak pmaytak commented May 10, 2020

In both sample client projects:

  • moved the cookie consent bar to bottom. (Currently it completely hides the menu bar, which is a bit confusing.)
    Before:
    image

  • updated images on home pages.
    Before:
    image
    After:
    image

@pmaytak pmaytak requested review from jmprieur and jennyf19 May 10, 2020 22:02
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe these should also go in the external samples?

@pmaytak
Copy link
Contributor Author

pmaytak commented May 11, 2020

@jennyf19 Perhaps. I can take a look. Although I don't have any samples set up, so can't really test. But I can send a PR.

…he cookie consent bar to bottom to unhide the menu.
@pmaytak pmaytak force-pushed the pmaytak/samplesUIFix branch from 3b47928 to 9f96207 Compare May 11, 2020 04:35
@pmaytak pmaytak merged commit d8608bb into master May 11, 2020
@pmaytak pmaytak deleted the pmaytak/samplesUIFix branch May 11, 2020 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants