some suggestions and add license info #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
approved these changes
May 14, 2020
There was a problem hiding this comment.
Thanks @jennyf19
LGTM
I might revert the GraphServiceClient -> IGraphServiceClient when we hear from @darrelmiller
jmprieur
added a commit
that referenced
this pull request
May 26, 2020
…rviceClient (#159) * Adding a sample using the Singleton Token acquisition and the GraphServiceClient * some suggestions and add license info (#160) * Adressing most PR comments - GraphServiceClient instead of IGraphServiceClient per Graph SDK guidance (@darrelmiller) - Adding the handling of the incremental consent in the Razor model - Moving the default scopes to AddMicrosoftGraph and adding a setting to express the Graph base URL (for national clouds for instance) - Renaming the token credential provider Co-authored-by: jennyf19 <jeferrie@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I included Peter's suggestions.