Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Id Web to use lang version 11 across repo #2359

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Updated Id Web to use lang version 11 across repo #2359

merged 3 commits into from
Aug 2, 2023

Conversation

FuPingFranco
Copy link
Contributor

@FuPingFranco FuPingFranco commented Jul 31, 2023 •
edited
Loading

Update C# lang version to 11

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Updated lang version to use 11 across Id Web repo.

Fixes #2351

@FuPingFranco FuPingFranco linked an issue Jul 31, 2023 that may be closed by this pull request
Use langversion 11 #2351
Closed
jmprieur
jmprieur requested changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some settings are not needed

tests/Directory.Build.props Show resolved Hide resolved
tools/app-provisioning-tool/Directory.Build.props Show resolved Hide resolved
tests/DevApps/aspnet-mvc/OwinWebApi/OwinWebApi.csproj Show resolved Hide resolved
tests/DevApps/daemon-app/Daemon-app/Daemon-app.csproj Show resolved Hide resolved
jennyf19
jennyf19 requested changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@jennyf19
Copy link
Collaborator

jennyf19 commented Aug 1, 2023

Is this all updated now @FuPingFranco ?

@FuPingFranco
Copy link
Contributor Author

Is this all updated now @FuPingFranco ?

Yes, It is now I forgot to update this as I was working on the nullables my apologies.

@jennyf19 jennyf19 reopened this Aug 1, 2023
jmprieur
jmprieur approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @FuPingFranco

@FuPingFranco FuPingFranco merged commit e9e015e into master Aug 2, 2023
@jennyf19 jennyf19 added this to the 2.13.3 milestone Aug 2, 2023
@jmprieur jmprieur deleted the francofung/updating_lang_version branch October 12, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13.3
Development

Successfully merging this pull request may close these issues.

Use langversion 11
3 participants
@FuPingFranco @jennyf19 @jmprieur