Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs in session cache provider. #265

Merged
merged 1 commit into from
Jun 29, 2020
Merged

fix bugs in session cache provider. #265

merged 1 commit into from
Jun 29, 2020

Conversation

jennyf19
Copy link
Collaborator

  • remove static
  • remove commit, as it's done automatically

for testing:
In Startup.cs:
• using Microsoft.Identity.Web.TokenCacheProviders.Session;
•  services.AddInMemoryTokenCaches(); replace with services.AddSessionTokenCaches();
In Startup.cs, in the configure method: Configure
app.UseSession();
before
app.UseAuthentication();

#252

- remove static
- remove commit, as it's done automatically
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks @jennyf19

@jmprieur
Copy link
Collaborator

Tested (and updated the wiki: https://github.com/AzureAD/microsoft-identity-web/wiki/token-cache-serialization#session-token-cache)

@jennyf19 jennyf19 merged commit 9c532ba into master Jun 29, 2020
@jennyf19 jennyf19 deleted the jennyf/sessionCache branch June 29, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants