Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloning TokenValidationParameters before use. #282

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Cloning TokenValidationParameters before use. #282

merged 1 commit into from
Jul 3, 2020

Conversation

pmaytak
Copy link
Contributor

@pmaytak pmaytak commented Jul 2, 2020

Issue #241

jmprieur
jmprieur approved these changes Jul 2, 2020
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @pmaytak

@pmaytak pmaytak force-pushed the pmaytak/tokenParamsClone branch from c7c213e to f724ebd Compare July 3, 2020 05:44
@pmaytak pmaytak force-pushed the pmaytak/tokenParamsClone branch from f724ebd to 49ce1ec Compare July 3, 2020 05:45
@pmaytak pmaytak merged commit aa72fad into master Jul 3, 2020
@pmaytak pmaytak deleted the pmaytak/tokenParamsClone branch July 3, 2020 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

@jmprieur jmprieur jmprieur approved these changes

@brentschmaltz brentschmaltz Awaiting requested review from brentschmaltz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmaytak @jmprieur @jennyf19