New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.Identity.Web token acquisition extensions #3005

Merged

jmprieur merged 25 commits into master from jmprieur/IdWebAddIns

Oct 25, 2024

Collaborator

jmprieur commented Sep 9, 2024 •

edited by trwalke

Loading

Work left (addressing PR feedback)

Rename the TokenAcquisitionAddInOptions to TokenAcquisitionExtensionOptions
Rename the tokenAcquisitionAddInOptionsMonitor variable to tokenAcquisitionExtensionOptionsMonitor, and addInOptions to tokenAcquisitionExtensionOptions in TokenAcquisition.cs
Split the delegages/types in the current file TokenAcquisitionAddIn.cs to their own files.
For the moment (until we add more extensions), add the events that are not used by the product in a #if FUTURE.
Create a better end to end test (using the ExtraParameters, with extension methods to set a Prefix), and adding a prefix in front of the acquired token?

jmprieur added 2 commits

September 9, 2024 08:40


          First cut or proto for IdWeb add-ins

7e1f503


          Merge branch 'master' into jmprieur/IdWebAddIns

5fbeaad

bgavrilMS reviewed

View reviewed changes

src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisitionAddIn.cs Outdated Show resolved Hide resolved

jmprieur and others added 4 commits

September 29, 2024 14:07


          Merge branch 'master' into jmprieur/IdWebAddIns

f4c2987


          Preparing work for CDT

71fddc2


          fix clone issue

d785a30


          remove cdt tests

ef135ef

jennyf19 reviewed

View reviewed changes

Microsoft.Identity.Web.sln Outdated Show resolved Hide resolved


          remove test

b632fc0

jennyf19 reviewed

View reviewed changes

Microsoft.Identity.Web.sln Outdated Show resolved Hide resolved


          remove endProject

77bab04

jennyf19 reviewed

View reviewed changes

Microsoft.Identity.Web.sln Outdated Show resolved Hide resolved


          fix sln

b1932b3

jennyf19 reviewed

View reviewed changes

Microsoft.Identity.Web.sln Outdated Show resolved Hide resolved

jennyf19 reviewed

View reviewed changes

Microsoft.Identity.Web.sln Outdated Show resolved Hide resolved

jennyf19 reviewed

View reviewed changes

Microsoft.Identity.Web.sln Outdated Show resolved Hide resolved


          Apply suggestions from code review

89524cc

fix sln

jmprieur mentioned this pull request

[Feature Request] Token Acquisition Extensibility support #2975

Closed

jmprieur added 2 commits

October 1, 2024 09:38


          Updarting to MSAL.NET 4.65.2-preview

39f904c

and fixing Travis's change


          Update NuGet.Config

24afdc3

jmprieur commented

View reviewed changes

NuGet.Config Outdated Show resolved Hide resolved


          Update NuGet.Config

73ff6a4

jmprieur commented

View reviewed changes

NuGet.Config Outdated Show resolved Hide resolved

jmprieur added 2 commits

October 1, 2024 15:40


          Update NuGet.Config

2bee7c8


          Update NuGet.Config

bc452d9

jmprieur commented

View reviewed changes

NuGet.Config Outdated Show resolved Hide resolved

jmprieur added 2 commits

October 1, 2024 17:58


          Merge from master

21fe340


          Updating the signature of the delegates

552b9e1

jmprieur marked this pull request as ready for review

October 3, 2024 00:14

jmprieur requested a review from a team as a code owner

October 3, 2024 00:14


          Update to use MSAL.NET preview

7b03eb8

jmprieur requested review from bgavrilMS and jennyf19

October 3, 2024 00:21

jmprieur changed the title ~~Prototype of Microsoft.Identity.Web token acquisition add-ins~~ [Do not merge before MSAL non-preview] Prototype of Microsoft.Identity.Web token acquisition add-ins

jmprieur added do not merge 1P labels

bgavrilMS reviewed

View reviewed changes

src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisitionAddIn.cs Outdated Show resolved Hide resolved

bgavrilMS reviewed

View reviewed changes

src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquirer.cs Show resolved Hide resolved

bgavrilMS reviewed

View reviewed changes

src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisitionAddIn.cs Outdated Show resolved Hide resolved

bgavrilMS reviewed

View reviewed changes

src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisitionAddIn.cs Outdated Show resolved Hide resolved

bgavrilMS reviewed

View reviewed changes

tests/Microsoft.Identity.Web.Test/TokenAcquisitionAddInTests.cs Outdated Show resolved Hide resolved

bgavrilMS previously requested changes

View reviewed changes

Member

bgavrilMS left a comment

ExtraParameters, OnAfterTokenAcquisition and OnBuildConfidentialClientApplication are not used / invoked by the product code.

bgavrilMS reviewed

View reviewed changes

Member

bgavrilMS left a comment •

edited

Loading

Discussed offline about unused events. Not blocking on this.

If you want to leave them in, maybe throw an "NotImplementedException" when an event is registered?

jmprieur and others added 3 commits

October 4, 2024 20:15


          Fixing a cloning issue

8ab01cc


          Merge from master

357e49d


          use msal preview version

88abe2c

Member

trwalke commented Oct 22, 2024

Working on addressing PR feedback and finishing PR

Member

trwalke commented Oct 23, 2024

Merging from here: #3100

jmprieur and others added 2 commits

October 24, 2024 11:01


          Update from master

244d4bb


          id web extension updates (#3100)

7942f6b

* WIP Refactoring code

* Updating test

* Updating test

* Clean up. Removing future code

* Creating partial class

* PR Feedback

* internal api updates

* Update public api

---------

Co-authored-by: trwalke <trwalke@microsoft.com>

jmprieur changed the title ~~[Do not merge before MSAL non-preview] Prototype of Microsoft.Identity.Web token acquisition add-ins~~ Microsoft.Identity.Web token acquisition extensions

jmprieur requested a review from bgavrilMS

October 24, 2024 22:21


          Merge branch 'master' into jmprieur/IdWebAddIns

3f6cfa1

jmprieur removed the do not merge label


          Fix Unshipped files for TokenAcquisition

72d8d81

jennyf19 approved these changes

View reviewed changes

jmprieur dismissed bgavrilMS’s stale review

October 25, 2024 01:11

Uodates

jmprieur merged commit 50bdedf into master

5 checks passed

jmprieur deleted the jmprieur/IdWebAddIns branch

October 25, 2024 01:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1P