Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull client_info from the protocol message not the form #303

Merged
merged 2 commits into from
Jul 9, 2020
Merged

pull client_info from the protocol message not the form #303

merged 2 commits into from
Jul 9, 2020

Conversation

jennyf19
Copy link
Collaborator

@jennyf19 jennyf19 commented Jul 9, 2020 •
edited by jmprieur
Loading

Fixes #245

pmaytak
pmaytak approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jmprieur
jmprieur approved these changes Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks @jennyf19

@jennyf19 jennyf19 merged commit 4e8a66d into master Jul 9, 2020
@jennyf19 jennyf19 deleted the jennyf/fixUserInfo branch July 9, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmaytak pmaytak pmaytak approved these changes

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Read the userinfo endpoint values from the protocol message rather than the form
3 participants
@jennyf19 @jmprieur @pmaytak