-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix validating B2C issuer with tfp in issuer URI. #340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pmaytak
Let's circle back with the B2C team as my understanding is they want to discourage the use of tfp.
I should probably have reacted a bit earlier, but I'd want to make sure we really want to support this scenario.
I agree, i'll ping b2c and see what they say about this. we don't want to necessarily support legacy stuff if we don't have to. i would like to get more context on that before moving forward. |
So, a couple of options:
|
@pmaytak. Given the reply from the B2C team and the customer, I think we could do 3.
|
2b544f3
to
41455a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I wonder what the md file is. Is it for the wiki?
edfd2f4
to
21fb1cb
Compare
let's not include the .md file for this. thx. |
b25cfc3
to
d3f352f
Compare
Issue #274
Fix to validate the B2C issuer with
tfp
URI type (ex.{domain}/{tfp}/{tid}/{userFlow}/v2.0/
) correctly.More detail:
B2C tokens compatibility
Configure B2C JWT token compatibility