-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add token acquisition options #596
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3e6d41c
add token acquisition options for extensibility w/msal
jennyf19 5ac4562
add xml comments
jennyf19 b1c5bee
Merge branch 'master' into jennyf/tokenOptions
jennyf19 cc6a3d8
add force refresh logic
jennyf19 221775e
update test
jennyf19 28ec7ca
remove using
jennyf19 07efd3f
add force refresh + test
jennyf19 3dafa34
remove unused variable
jennyf19 9b76f11
merge conflict
jennyf19 82b4835
PR feedback
jennyf19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,6 +46,11 @@ public class DownstreamWebApiOptions | |
/// </summary> | ||
public HttpMethod HttpMethod { get; set; } = HttpMethod.Get; | ||
|
||
/// <summary> | ||
/// Options passed-in to create the token acquisition object which calls into MSAL .NET. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. token acquisition options object ? #Resolved |
||
/// </summary> | ||
public TokenAcquisitionOptions TokenAcquisitionOptions { get; set; } = new TokenAcquisitionOptions(); | ||
|
||
/// <summary> | ||
/// Clone the options (to be able to override them). | ||
/// </summary> | ||
|
@@ -60,6 +65,7 @@ public DownstreamWebApiOptions Clone() | |
Tenant = Tenant, | ||
UserFlow = UserFlow, | ||
HttpMethod = HttpMethod, | ||
TokenAcquisitionOptions = TokenAcquisitionOptions.Clone(), | ||
}; | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch for missing
user
#Resolved