Removing existing authorization token #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
approved these changes
Oct 10, 2020
There was a problem hiding this comment.
Thanks for this PR, @davesmits
This looks good.
I've provided a suggestion for improvement.
| @@ -30,6 +30,12 @@ public TokenAcquisitionCredentialProvider(ITokenAcquisition tokenAcquisition, IE | |||
| /// <returns>A Task (as this is an async method).</returns> | |||
| public async Task AuthenticateRequestAsync(HttpRequestMessage request) | |||
| { | |||
| // In case of a retry there is already an authorization header; replace it with new one to avoid using expired token | |||
| if (request.Headers.Contains(Constants.Authorization)) | |||
There was a problem hiding this comment.
What about the following?
request.Headers[Constants.Authorization] = string.Format(
CultureInfo.InvariantCulture,
"{0} {1}",
Constants.Bearer,
await _tokenAcquisition.GetAccessTokenForUserAsync(_initialScopes).ConfigureAwait(false)));There was a problem hiding this comment.
the HttpHeaders doesn't have a indexer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing bug #673
I tried to leave it as much intact as is with the string format but personally i like this syntax more but not sure if I am missing something with the string format