Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add net461 target for cache extensions #737

Merged
merged 3 commits into from
Nov 3, 2020
Merged

add net461 target for cache extensions #737

merged 3 commits into from
Nov 3, 2020

Conversation

jennyf19
Copy link
Collaborator

@jennyf19 jennyf19 commented Nov 2, 2020

@jmprieur as discussed

@jennyf19 jennyf19 marked this pull request as draft November 2, 2020 20:15
@jennyf19 jennyf19 marked this pull request as ready for review November 2, 2020 22:17
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @jennyf19, and this opens the way to delivering even more value for the ASP.NET customers.

@henrik-me : is it an option to support .NET 4.7.2 instead of .NET 4.6.1 ? this would also give us the certificate management with only one line of conditional compilation (with 4.6.1 the crypto is a bit different)

@henrik-me
Copy link
Contributor

This is awesome @jennyf19, and this opens the way to delivering even more value for the ASP.NET customers.

@henrik-me : is it an option to support .NET 4.7.2 instead of .NET 4.6.1 ? this would also give us the certificate management with only one line of conditional compilation (with 4.6.1 the crypto is a bit different)

4.7.2 is recommended in many ways. Not sure every one is there yet though and what the timeline will be (probably most by end of CY). Will require a bit of investigation on current usages.

Perhaps we can start with 4.7.2?

@jennyf19
Copy link
Collaborator Author

jennyf19 commented Nov 2, 2020

@henrik-me @jmprieur ok. thanks.

Copy link
Contributor

@henrik-me henrik-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@henrik-me
Copy link
Contributor

henrik-me commented Nov 2, 2020

perhaps a utest validating that this the expected is available for the 4.7.2 target. #Resolved

@jmprieur
Copy link
Collaborator

jmprieur commented Nov 3, 2020

We could even expose the certificate management (including getting them from keyVault), by changing one line in DefaultCertificateLoader.cs:

line 97
from string[] segments = certificate.SecretId.AbsolutePath.Split('/', StringSplitOptions.RemoveEmptyEntries);`` to string[] segments = certificate.SecretId.AbsolutePath.Split(new[] { '/' }, StringSplitOptions.RemoveEmptyEntries);` #Resolved

@jmprieur
Copy link
Collaborator

jmprieur commented Nov 3, 2020

@jennyf19
Copy link
Collaborator Author

jennyf19 commented Nov 3, 2020

i'm going to add a test app instead. so we can verify all the classes taht are added e2e.


In reply to: 720773691 [](ancestors = 720773691)

@jennyf19
Copy link
Collaborator Author

jennyf19 commented Nov 3, 2020

maybe in a next PR?


In reply to: 721111217 [](ancestors = 721111217)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@henrik-me
Copy link
Contributor

I don't really like the test apps for something like this, but can be clarified as required validation step when checking the API.
I would prefer a utest project that validates this. We should not require any manual validation of this.
Also the sample should demonstrate the usage of this (I believe JM already made some of those changes to the sample)


In reply to: 721338397 [](ancestors = 721338397,720773691)

@jmprieur
Copy link
Collaborator

jmprieur commented Nov 4, 2020

yes, this is demonstrated in the sample: Azure-Samples/ms-identity-aspnet-webapp-openidconnect#43
I've also updated the release spreadsheet

@jmprieur jmprieur deleted the jennyf/net461 branch November 7, 2020 17:51
@jennyf19
Copy link
Collaborator Author

jennyf19 commented Nov 9, 2020

@henrik-me #754 for adding test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants