Added unit tests for WebApi ServiceCollection and AuthenticationBuilder extensions. Minor fixes. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmaytak
commented
Apr 10, 2020
jennyf19
reviewed
Apr 10, 2020
| @@ -121,6 +122,8 @@ public static class WebApiServiceCollectionExtensions | |||
|
|
|||
| services.Configure<JwtBearerOptions>(jwtBearerScheme, options => | |||
| { | |||
| options.Events ??= new JwtBearerEvents(); | |||
|
|
|||
There was a problem hiding this comment.
What do you mean? @jennyf19
There was a problem hiding this comment.
There shouldn't be one. It's compound operator.
There was a problem hiding this comment.
Hah, never used this operator before. It's nice to see smth new :)
jennyf19
reviewed
Apr 10, 2020
pmaytak
force-pushed
the
pmaytak/unitTests
branch
from
955f805 to
3f62ec4
Compare
…er extensions. Minor fixes.
pmaytak
force-pushed
the
pmaytak/unitTests
branch
from
3f62ec4 to
05c2b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests for
Note: I put them into one test class as the tests are pretty much the same.