Enable thread-local destructors on horizon #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureMarker
reviewed
Mar 25, 2022
| @@ -93,7 +93,7 @@ pub unsafe fn register_dtor(t: *mut u8, dtor: unsafe extern "C" fn(*mut u8)) { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(target_os = "vxworks")] | |||
| #[cfg(target_os = "vxworks", target_os = "horizon")] | |||
| pub unsafe fn register_dtor(t: *mut u8, dtor: unsafe extern "C" fn(*mut u8)) { | |||
There was a problem hiding this comment.
Does this make sense to do before enabling #[thread_local]?
There was a problem hiding this comment.
I don't think there's any harm in it, since the only usage of this function is behind a #[cfg(target_thread_local)]: https://github.com/ian-h-chamberlain/rust-horizon/blob/feature/target-thread-local/library/std/src/thread/local.rs#L531
That said, I realized while double checking it that I screwed up the syntax of this cfg, so let me fix that...
There was a problem hiding this comment.
Does this make sense to do before enabling
#[thread_local]?
Will be merged in a couple hours by bors. This PR can get merged.
Edit: merged 👍
Meziu
approved these changes
Mar 26, 2022
AzureMarker
pushed a commit
that referenced
this pull request
Jun 14, 2022
Always use fallback thread_local destructor, since __cxa_thread_atexit_impl is never defined on the target. See #2
workingjubilee
pushed a commit
to tcdi/postgrestd
that referenced
this pull request
Sep 15, 2022
Always use fallback thread_local destructor, since __cxa_thread_atexit_impl is never defined on the target. See AzureMarker/rust-horizon#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AzureMarker @Meziu
Broken out from Meziu#16
Always use fallback thread_local destructor.