Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real Housing - GS update #395

Open
wants to merge 2 commits into
base: expansion2
Choose a base branch
from
Open

Conversation

bollbas
Copy link
Contributor

@bollbas bollbas commented Apr 2, 2019

Update Real Housing to game version 1.0.0.290

Update Real Housing to game version 1.0.0.290
@bollbas
Copy link
Contributor Author

bollbas commented Apr 2, 2019

I've also added a bug to show correct values until it will be fixed by developers.

* Fixed Seasteads and Golf Courses didn't counted when calculating housing from improvements.
* Fixed described bug function to correctly calculate housing for cities with the same IDs.
@Azurency
Copy link
Owner

Azurency commented May 3, 2019

@bollbas I talked to the developers about this bug, and gave them the link to your post. They are looking into it. So I hope it's going to be fixed in a near future patch.

@bollbas
Copy link
Contributor Author

bollbas commented May 5, 2019

@Azurency wow, that's great, thank you! I track this bug since I've first found it in 1.0.0.257. But anyway if you want to show correct housing values in CQUI until it will be fixed you should merge these commits. And after fixing we can easily correct this function again.

@Azurency
Copy link
Owner

Azurency commented May 5, 2019

They found the bug apparently and it should be fixed in the next update ;). I'll see about merging this until it's released.

@bollbas
Copy link
Contributor Author

bollbas commented May 27, 2019

By the way this pull request not only adds the described bug function but also adds housing calculation for Seasteads and Cahokia Mounds from GS and fixes my previous mistake with wrong housing calculation for Golf Courses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants