Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: Add .devcontainer/devcontainer.json #366

Merged
merged 3 commits into from
Oct 15, 2023
Merged

[FEAT]: Add .devcontainer/devcontainer.json #366

merged 3 commits into from
Oct 15, 2023

Conversation

gmacario
Copy link
Member

@gmacario gmacario commented Oct 14, 2023 •
edited
Loading

📑 Description

Closes #354

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@gmacario
Add .devcontainer/devcontainer.json
77532f2 
Signed-off-by: Gianpaolo Macario <gmacario@gmail.com>
@gmacario gmacario linked an issue Oct 14, 2023 that may be closed by this pull request
[FEAT]: Configure Dev Container for the ARNEIS project #354
Closed
@gmacario gmacario self-assigned this Oct 14, 2023
@gmacario gmacario added the enhancement New feature or request label Oct 14, 2023
@gmacario gmacario added this to the dev-cw41 milestone Oct 14, 2023
@gmacario gmacario requested a review from alv67 October 14, 2023 12:21
@gmacario gmacario marked this pull request as draft October 14, 2023 12:22
@gmacario gmacario marked this pull request as ready for review October 15, 2023 05:40
@gmacario
Copy link
Member Author

@alv67 kindly review and merge, please!

alv67
alv67 approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@alv67 alv67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to trust you.

@alv67 alv67 merged commit d454ba8 into main Oct 15, 2023
8 checks passed
@alv67 alv67 deleted the 354-feat-configure-dev-container-for-the-arneis-project branch October 15, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alv67 alv67 alv67 approved these changes

Assignees

@gmacario gmacario

Labels
enhancement New feature or request
Projects
None yet
Milestone
2023-cw41
Development

Successfully merging this pull request may close these issues.

[FEAT]: Configure Dev Container for the ARNEIS project
2 participants
@gmacario @alv67