-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes for 2024.01 #667
Conversation
In the generated PDF (downloaded from the GitHub CI artifact generated on Ubuntu 22.04), I notice that the unicode ring operator character is not properly displayed, when viewed on my Mac. Is anyone else seeing that? Is that a failure in the document or just in my viewer? |
i think they're just missing in the font asciidoctor is using. running asciidoctor like this worked for me:
|
Thank you! That change also worked for me, so I have a pushed a commit which updates the Makefile. The command in the Makefile was not specifying an explicit theme and so it was using |
Hm, that change works on my mac but broke on the Ubuntu VM:
However, the following syntax works for older Asciidoctor as well as newer, so I'll push a commit that uses that:
The version of Asciidoctor PDF that is installed by the Ubuntu 22.04 package manager is an old version:
whereas on my macOS 11 I have:
We could change the CI to install a newer version of Asciidoctor PDF, if we think it makes a difference to the quality of the output. |
d7e25be
to
60d283a
Compare
I spoke too soon. The version of asciidoctor-pdf being installed by the Ubuntu package manager was too old to have the theme we wanted. So I pushed a commit that updates asciidoctor-pdf in the GitHub CI job (by calling |
Since the release has ended up being delayed somewhat, should it be named 2024.3 instead of 2024.1? |
I can ask around, but our policy has been to not rename the two planned releases each year (YYYY.01 and YYYY.07) even if they are delayed. |
This requires using a newer version of asciidoctor-pdf. So in the GitHub CI job that builds the release notes on ubuntu-22.04, use gem to install the latest version over what the package manager installs.
No description provided.