Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRMO-55] Integratie bgt-loader in brmo-service #1149

Merged
merged 4 commits into from
Aug 24, 2021

Conversation

mprins
Copy link
Member

@mprins mprins commented Aug 12, 2021

close BRMO-55

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #1149 (3fdb296) into master (c4b486a) will decrease coverage by 0.09%.
The diff coverage is 4.67%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1149      +/-   ##
============================================
- Coverage     17.74%   17.65%   -0.10%     
  Complexity      809      809              
============================================
  Files           532      535       +3     
  Lines         27291    27453     +162     
  Branches       2368     2378      +10     
============================================
+ Hits           4843     4846       +3     
- Misses        22038    22194     +156     
- Partials        410      413       +3     
Impacted Files Coverage Δ
.../main/java/nl/b3p/brmo/bgt/loader/BGTDatabase.java 64.28% <0.00%> (-3.22%) ⬇️
.../b3p/brmo/persistence/staging/BGTLoaderProces.java 0.00% <0.00%> (ø)
...brmo/service/scanner/AbstractExecutableProces.java 6.81% <0.00%> (-0.16%) ⬇️
...in/java/nl/b3p/brmo/service/scanner/BGTLoader.java 0.00% <0.00%> (ø)
.../nl/b3p/brmo/service/scanner/ProcesExecutable.java 0.00% <0.00%> (ø)
.../service/stripes/BGTLoaderUitvoerenActionBean.java 0.00% <0.00%> (ø)
...p/brmo/service/stripes/OphaalConfigActionBean.java 0.00% <0.00%> (ø)
...java/nl/b3p/brmo/bgt/loader/cli/BGTLoaderMain.java 76.00% <50.00%> (-0.88%) ⬇️
...va/nl/b3p/brmo/bgt/loader/cli/DownloadCommand.java 63.11% <50.00%> (-2.41%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4b486a...3fdb296. Read the comment docs.

@mprins mprins force-pushed the BRMO-55_bgt-loader_integratie branch from 3c7bc09 to c54adc9 Compare August 23, 2021 13:07
@mprins mprins force-pushed the BRMO-55_bgt-loader_integratie branch 2 times, most recently from 9e4ce2b to 973186b Compare August 24, 2021 09:36
@mprins mprins marked this pull request as ready for review August 24, 2021 12:53
exclude aalto stax om te kijken of integratie tests wel passeren
met een paar kleine refactorings in de bgt-loader om het mogelijk te maken een JNDI datasoure te gebruiken ipv url+username+password.
@mprins mprins force-pushed the BRMO-55_bgt-loader_integratie branch from 3159c89 to 3fdb296 Compare August 24, 2021 12:57
@mprins mprins enabled auto-merge August 24, 2021 14:33
@mprins mprins merged commit 5fef4e6 into master Aug 24, 2021
@mprins mprins deleted the BRMO-55_bgt-loader_integratie branch August 24, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant