Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameter class #59

Closed
CagtayFabry opened this issue Jul 6, 2020 · 0 comments · Fixed by #76 or #64
Closed

parameter class #59

CagtayFabry opened this issue Jul 6, 2020 · 0 comments · Fixed by #76 or #64
Assignees
Labels
ASDF everything ASDF related (python + schemas) task

Comments

@CagtayFabry
Copy link
Member

CagtayFabry commented Jul 6, 2020

Create base class for parameters. This class should represent nominal value (e.g. power source settings but also general metadata).
Parameters can be time dependent by default (see below)
All values should be Quantity (dimensionless allowed)

time dependency

  • provide interp_time functionality
  • define custom interpolation behavior (step,linear,spline ...)

implementation variations

  • single quantity value without time for constant values
  • quantity array + time (as pd.Timedelta or pint.Quantity) + interpolation style
    • time dependency implemented as xarray.DataArray with time dimension
  • MathematicalExpression with single undefined time parameter
@CagtayFabry CagtayFabry added task ASDF everything ASDF related (python + schemas) labels Jul 6, 2020
@vhirtham vhirtham linked a pull request Jul 16, 2020 that will close this issue
@CagtayFabry CagtayFabry linked a pull request Jul 30, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASDF everything ASDF related (python + schemas) task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants