Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeSeries #76

Merged
merged 68 commits into from
Jul 27, 2020
Merged

TimeSeries #76

merged 68 commits into from
Jul 27, 2020

Conversation

vhirtham
Copy link
Collaborator

No description provided.

@vhirtham vhirtham self-assigned this Jul 16, 2020
@vhirtham vhirtham linked an issue Jul 16, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #76 into dev_asdf will decrease coverage by 1.34%.
The diff coverage is 98.53%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev_asdf      #76      +/-   ##
============================================
- Coverage     99.40%   98.06%   -1.35%     
============================================
  Files            59       64       +5     
  Lines          2693     2944     +251     
============================================
+ Hits           2677     2887     +210     
- Misses           16       57      +41     
Impacted Files Coverage Δ
weldx/asdf/tags/weldx/core/__init__.py 100.00% <ø> (ø)
weldx/utility.py 98.85% <92.00%> (-1.15%) ⬇️
weldx/core.py 99.32% <99.32%> (ø)
weldx/__init__.py 100.00% <100.00%> (ø)
...dx/asdf/tags/weldx/core/mathematical_expression.py 100.00% <100.00%> (+15.15%) ⬆️
weldx/asdf/tags/weldx/core/time_series.py 100.00% <100.00%> (ø)
weldx/asdf/validators.py 78.72% <0.00%> (-14.08%) ⬇️
weldx/transformations.py 100.00% <0.00%> (ø)
weldx/asdf/tags/weldx/core/iso_groove.py 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d51b4...723561f. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Jul 20, 2020

Hello @vhirtham! Thanks for updating this PR.

Line 72:39: F541 f-string is missing placeholders

Comment last updated at 2020-07-27 09:00:22 UTC

weldx/measurement.py Outdated Show resolved Hide resolved
weldx/measurement.py Outdated Show resolved Hide resolved
weldx/utility.py Outdated Show resolved Hide resolved
Comment on lines +438 to +440
# store and strip pint units at this point, since the unit is lost during
# interpolation and because of some other conflicts. Unit is restored before
# returning the result.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do some testing if pint integration is improved with xarray 0.16.0 in this case

weldx/utility.py Outdated Show resolved Hide resolved
weldx/core.py Outdated Show resolved Hide resolved
weldx/core.py Outdated Show resolved Hide resolved
@vhirtham
Copy link
Collaborator Author

vhirtham commented Jul 24, 2020

TODO

  • enum in schema
  • data_array accessor

@vhirtham
Copy link
Collaborator Author

Reminder:

  • discuss the unit parameter of interp_time
  • remove interpolation attribute from the result of interp_time
  • isclose utility function for quantities

@vhirtham vhirtham merged commit be0fdac into dev_asdf Jul 27, 2020
@CagtayFabry CagtayFabry deleted the 59_parameter_class branch August 17, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parameter class
3 participants