Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct array layout during normalization and interpolation #25

Merged
merged 3 commits into from
Apr 28, 2020

Conversation

CagtayFabry
Copy link
Member

  • simplify normalize functions
  • make sure normalization is carried out on vectors (not matrix) during LCS construction
  • ensure correct matrix layout in xr_interp_orientation_in_time
  • remove duplicate checks in check_coordinate_system

- remove duplicate checks in check_coordinate_system
@CagtayFabry CagtayFabry added the bug Something isn't working label Apr 27, 2020
@CagtayFabry CagtayFabry requested a review from vhirtham April 27, 2020 16:59
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          932       930    -2     
=========================================
- Hits           932       930    -2     
Impacted Files Coverage Δ
weldx/transformations.py 100.00% <100.00%> (ø)
weldx/utility.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96be7fa...0dc4103. Read the comment docs.

Copy link
Collaborator

@vhirtham vhirtham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@vhirtham vhirtham merged commit 329f8e3 into master Apr 28, 2020
@vhirtham vhirtham deleted the fix_normalize_orientation branch April 28, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants