Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pint xarray #518

Merged
merged 110 commits into from
Nov 29, 2021
Merged

Pint xarray #518

merged 110 commits into from
Nov 29, 2021

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented Sep 14, 2021 •
edited
Loading

Changes

Checks

  • updated CHANGELOG.md
  • updated tests

vhirtham and others added 30 commits July 19, 2021 09:29
@vhirtham
Update CHANGELOG.md
9c2b803
@vhirtham
Add proposed interfaces
633faa8
@CagtayFabry
update annotation syntax using __future__
85172ac
@CagtayFabry
add __radd__ and __rsub__
cf96610
@vhirtham
Update weldx/time.py
b482a03
@vhirtham
Update weldx/time.py
949db29
@CagtayFabry
initial implementations
c841ffe
@CagtayFabry
initial implementations
9e5c032
@CagtayFabry
add test_time.py
55a5497
@CagtayFabry
Merge branch 'master' into 367_time_class
6540df7 
# Conflicts:
#	CHANGELOG.md
@CagtayFabry
move sine and lcs_coords_from_ts functions to welding module
3bd8ae8
@CagtayFabry
add as_pandas_index() interface
2993d38
@CagtayFabry
Merge branch 'refactor_util_functions' into timeseries_absolute_times
aed9829
@vhirtham
Merge branch 'master' into 367_time_class
33e258f
@vhirtham
Update tests
299003f
@CagtayFabry
test absolute time support in TimeSeries
d045307
@CagtayFabry
fix imports
f2e85f6
@CagtayFabry
fix imports
25cf56d
@CagtayFabry
fix imports
6b9357d
@CagtayFabry
fix imports
202a74d
@vhirtham
Also test __radd__ and 'Time' as other type
3536dfb
@vhirtham
Add missing __init__ testcases
3a26532
@CagtayFabry
Merge branch 'master' into refactor_util_functions
d2e6eaf
@CagtayFabry
keep reference time for timestamp data
a2538a9
@CagtayFabry
remove transformation import
0ee4864
@CagtayFabry
Merge branch 'refactor_util_functions' into timeseries_absolute_times
f4e37a7
@vhirtham
Rewrite __init__ test
7fd7096
@CagtayFabry
update type hints and docstrings, add equals
e4140ce
@CagtayFabry
Merge branch 'master' into 367_time_class
a257306
@CagtayFabry
fix monotonic check and udpate type hints
5e7f550
@CagtayFabry
Copy link
Member Author

I still need to add some test for different combinations of coordinates (units/time-types) and expand some docstrings

however in general this should be ready as an initial implementation that should work with units in xr_interp_like

@CagtayFabry CagtayFabry marked this pull request as ready for review November 23, 2021 22:12
@CagtayFabry CagtayFabry added this to the 0.6.0 milestone Nov 23, 2021
@CagtayFabry CagtayFabry requested a review from vhirtham November 23, 2021 22:13
@CagtayFabry CagtayFabry merged commit da81690 into BAMWelDX:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhirtham vhirtham vhirtham approved these changes

Assignees
No one assigned
Labels
units unit handling and pint xarray issues related to handling xarray objects
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@CagtayFabry @pep8speaks @vhirtham