Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measurement asdf #70

Merged
merged 39 commits into from
Jul 13, 2020
Merged

Measurement asdf #70

merged 39 commits into from
Jul 13, 2020

Conversation

CagtayFabry
Copy link
Member

No description provided.

@CagtayFabry CagtayFabry added ASDF everything ASDF related (python + schemas) measurements measurement and signal handling labels Jul 10, 2020
@pep8speaks
Copy link

pep8speaks commented Jul 10, 2020

Hello @CagtayFabry! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-07-10 12:48:37 UTC

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #70 into dev_asdf will decrease coverage by 0.42%.
The diff coverage is 97.19%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev_asdf      #70      +/-   ##
============================================
- Coverage     98.32%   97.89%   -0.43%     
============================================
  Files            47       61      +14     
  Lines          2263     2712     +449     
============================================
+ Hits           2225     2655     +430     
- Misses           38       57      +19     
Impacted Files Coverage Δ
weldx/asdf/tags/weldx/core/data_array.py 100.00% <ø> (ø)
weldx/asdf/tags/weldx/debug/const_class.py 80.95% <ø> (ø)
weldx/asdf/tags/weldx/debug/validator_testclass.py 100.00% <ø> (ø)
weldx/geometry.py 100.00% <ø> (ø)
...dx/asdf/tags/weldx/core/mathematical_expression.py 84.84% <84.84%> (ø)
weldx/asdf/validators.py 78.83% <91.01%> (+11.48%) ⬆️
...ore/transformations/coordinate_system_hierarchy.py 98.30% <98.30%> (ø)
weldx/__init__.py 100.00% <100.00%> (ø)
weldx/asdf/tags/weldx/__init__.py 100.00% <100.00%> (ø)
weldx/asdf/tags/weldx/core/__init__.py 100.00% <100.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d920636...2d9b73c. Read the comment docs.

@CagtayFabry CagtayFabry self-assigned this Jul 10, 2020
@CagtayFabry CagtayFabry marked this pull request as ready for review July 10, 2020 13:23
@vhirtham vhirtham merged commit 930c5f9 into dev_asdf Jul 13, 2020
@CagtayFabry CagtayFabry deleted the measurement_asdf branch July 24, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASDF everything ASDF related (python + schemas) measurements measurement and signal handling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants