-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download single_pass_weld.wx
directly in the tutorials
#705
Download single_pass_weld.wx
directly in the tutorials
#705
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #705 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 92 92
Lines 6393 6393
=======================================
Hits 6141 6141
Misses 252 252 Continue to review full report at Codecov.
|
I think we could also remove the download inside the docs (conf.py), right? |
wasn't the idea to download the file once for the tests so that it is available? |
I think it is cleaner to use the |
If the notebooks download the file, we do not need to do it explicitly (even for the tests), right? That should be the case as all notebook cells will be executed by the tests in sequential order. The only thing that could happen then is a race condition, when two notebooks will start to download the file. This should be avoided as it leads to unpredictable test failures. |
I just wasn't sure about the parallel execution of the notebooks via pytest but that's ok for me too if it works |
not downloading in Sphinx works. The RTD error is unrelated. |
Changes
I added a hidden cell at the top in each of the new tutorials. This cell calls the function to download the needed
single_pass_weld.wx
file. The background is that you can't run those tutorials locally without the file but it is only downloaded when in another directory if you actually build the docs. I also edit a flag to the download function to suppress text outputs.Checks
updated CHANGELOG.rstupdated testsupdate manifest file