Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add git diff check #730

Merged
merged 22 commits into from
Mar 28, 2022
Merged

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented Mar 28, 2022

Changes

  • order the manifest contents outputs of devtools/scripts/update_manifest.py by filename for consistent manifest generation
  • add a git diff check in pytest_asdf.yml workflow against the output of devtools/scripts/update_manifest.py (if this fails, try running devtools/scripts/update_manifest.py locally and commit changes)

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #730 (ecfeb3c) into master (228554b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #730   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files          92       92           
  Lines        6496     6496           
=======================================
  Hits         6229     6229           
  Misses        267      267           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228554b...ecfeb3c. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 28, 2022

Unit Test Results

       1 files  ±0         1 suites  ±0   3m 5s ⏱️ -31s
2 158 tests ±0  2 158 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit ecfeb3c. ± Comparison against base commit 228554b.

♻️ This comment has been updated with latest results.

@CagtayFabry CagtayFabry marked this pull request as ready for review March 28, 2022 12:14
@CagtayFabry
Copy link
Member Author

CagtayFabry commented Mar 28, 2022

This should make it easier to find bugs in the asdf manifest and Converter setups

If the action fails at the git diff step run the update_manifest.py script (must be executed in the devtools/scripts folder) to fix @marscher @vhirtham

@CagtayFabry CagtayFabry merged commit af9df21 into BAMWelDX:master Mar 28, 2022
@CagtayFabry CagtayFabry deleted the update_manifest_check branch March 28, 2022 16:46
@CagtayFabry CagtayFabry mentioned this pull request Mar 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant