-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom wx_unit
validation behavior
#739
Conversation
We still have to think about the behavior when not unit information can be found or the property is missing as discussed in #184 |
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
==========================================
+ Coverage 95.88% 95.89% +0.01%
==========================================
Files 92 92
Lines 6489 6511 +22
==========================================
+ Hits 6222 6244 +22
Misses 267 267
Continue to review full report at Codecov.
|
This should be ready to go now, feel free to merge if you agree @vhirtham 🚀 |
Thanks for this improvement. Would it be possible to also accept |
I'm not sure what happens with maybe you can give it a try by making changes here and running the tests weldx/weldx/schemas/weldx.bam.de/weldx/debug/test_unit_validator-0.1.0.yaml Lines 59 to 61 in f64658d
|
Changes
units_from_tagged
and_get_instance_units
data_array
now directly supports validation withwx_unit
pd.Timedelta
,pd.TimedeltaIndex
and timedelta-likeweldx.Time
will validate againstwx_unit: "s"
Related Issues
Closes #95
Checks