Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.6.0 #744
v0.6.0 #744
Changes from all commits
adb9427
1f77bd2
5f0bf22
9e56055
6dbf88c
e797c06
5aadc50
b3dad32
73a684c
cd47450
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since somebody already merged the suggestion while I was editing it for additional content 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
safer to edit directly in the file I guess 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be deleted now? @marscher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason the first line below "changes" in the RTD version of the changelog is shown in bold letters:
https://weldx--744.org.readthedocs.build/en/744/changelog_link.html
Checked the changelog file and the only difference to the other lines that I could find is that the line in question has only a single space between the
-
and the text while all others have 2 spaces. I am not that familiar with RST, but I guess that's the problem.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CagtayFabry you were absolutely right about this deletion.
@vhirtham RST is sometimes also very picky with missing line breaks. But this should not cause usage of bold setting...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good find @vhirtham , let's see if it is fixed with the spaces (otherwise we can reformat later)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marscher argh... this should have been an extra comment ... ooops. Well let's see what fixes it