-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wxfile] raise KeyError for non-existent keys. #759
[wxfile] raise KeyError for non-existent keys. #759
Conversation
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
==========================================
+ Coverage 96.76% 96.86% +0.09%
==========================================
Files 88 88
Lines 6006 6005 -1
==========================================
+ Hits 5812 5817 +5
+ Misses 194 188 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for adding the test cases
Co-authored-by: Cagtay Fabry <43667554+CagtayFabry@users.noreply.github.com>
Changes
WeldxFile now raises a KeyError, if a given key could not be accessed. Previously only a warning was emitted and the change was ignored. As this leads to confusion, e.g. None being returned, we now trigger the exception.
Related Issues
Closes #757
Checks