Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "set networkx<=2.8.0" #763

Merged
merged 5 commits into from
May 31, 2022
Merged

Revert "set networkx<=2.8.0" #763

merged 5 commits into from
May 31, 2022

Conversation

marscher
Copy link
Contributor

@marscher marscher commented May 21, 2022

Reverts #761

xref: networkx/networkx#5655

networkx-2.8.2 just got released, so we should pin like ..., !=2.8.1

@github-actions
Copy link

github-actions bot commented May 21, 2022

Unit Test Results

       1 files  ±0         1 suites  ±0   2m 24s ⏱️ -1s
2 152 tests ±0  2 152 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 248d554. ± Comparison against base commit cc3ac01.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #763 (248d554) into master (cc3ac01) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #763   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files          88       88           
  Lines        6009     6009           
=======================================
  Hits         5819     5819           
  Misses        190      190           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3ac01...248d554. Read the comment docs.

@marscher marscher marked this pull request as ready for review May 23, 2022 11:32
@marscher
Copy link
Contributor Author

this should be all green after #765

@marscher marscher requested a review from vhirtham May 31, 2022 11:12
@marscher marscher merged commit ceaa4c5 into master May 31, 2022
@marscher marscher deleted the revert-761-fix_networkx branch May 31, 2022 12:14
@CagtayFabry
Copy link
Member

since we already released 0.6.1 with these dependencies I would prefer not to alter the changelog (and move it to the next release section)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants