Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LCS tutorial #775

Merged
merged 20 commits into from
Jul 19, 2022
Merged

Update LCS tutorial #775

merged 20 commits into from
Jul 19, 2022

Conversation

vhirtham
Copy link
Collaborator

@vhirtham vhirtham commented Jun 21, 2022

Changes

Update the tutorial about the LCS.

Checks

  • updated CHANGELOG.rst
  • updated tests
  • updated doc/
  • update example/tutorial notebooks
  • update manifest file

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@vhirtham vhirtham added documentation Improvements or additions to documentation transformations everything related to the LCS / CSM labels Jun 21, 2022
@github-actions
Copy link

github-actions bot commented Jun 21, 2022

Unit Test Results

2 153 tests  ±0   2 153 ✔️ ±0   2m 26s ⏱️ -38s
       1 suites ±0          0 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 6894d0d. ± Comparison against base commit 797d0ec.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #775 (266e1fb) into master (d6f5ca5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #775   +/-   ##
=======================================
  Coverage   96.77%   96.77%           
=======================================
  Files          88       88           
  Lines        6017     6017           
=======================================
  Hits         5823     5823           
  Misses        194      194           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6f5ca5...266e1fb. Read the comment docs.

@vhirtham vhirtham marked this pull request as ready for review June 22, 2022 12:54
@vhirtham vhirtham requested a review from marscher June 22, 2022 12:54
@vhirtham
Copy link
Collaborator Author

@marscher Do you remember how to tell nbconvert that it should only print the output but not the code of a cell?

@vhirtham
Copy link
Collaborator Author

@marscher Do you remember how to tell nbconvert that it should only print the output but not the code of a cell?

Okay, should be this

@vhirtham
Copy link
Collaborator Author

@marscher Do you remember how to tell nbconvert that it should only print the output but not the code of a cell?

Okay, should be this

Doesn't seem to work cause it also hides the output. I can hide the code cell in jupyter directly, but in the sphinx-doc, the cell is still rendered. Any idea?

@github-actions
Copy link

github-actions bot commented Jul 19, 2022

Test Results

2 153 tests  ±0   2 153 ✔️ ±0   3m 19s ⏱️ +52s
       1 suites ±0          0 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 266e1fb. ± Comparison against base commit d6f5ca5.

♻️ This comment has been updated with latest results.

@vhirtham vhirtham merged commit c218595 into master Jul 19, 2022
@vhirtham vhirtham deleted the update_lcs_tut branch July 19, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation transformations everything related to the LCS / CSM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant