Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update link to weldx tutorial files for v0.6.0 #804

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

CagtayFabry
Copy link
Member

Changes

Update the tutorials to use the latest example file created with weldx 0.6.0

Checks

  • update example/tutorial notebooks

@CagtayFabry CagtayFabry added documentation Improvements or additions to documentation no-changelog-entry-needed labels Sep 22, 2022
@CagtayFabry CagtayFabry assigned marscher and unassigned marscher Sep 22, 2022
@CagtayFabry
Copy link
Member Author

CagtayFabry commented Sep 22, 2022

The old file was giving a warning on load
https://weldx.readthedocs.io/en/latest/tutorials/01_04_coordinate_systems.html#Dependency-graph

...
single_pass_weld.wx' was created with extension URI 'asdf://weldx.bam.de/weldx/extensions/weldx-0.1.0' (from package weldx==0.5.0), which is not currently installed
  warnings.warn(msg, AsdfWarning)

@github-actions
Copy link

github-actions bot commented Sep 22, 2022

Test Results

2 185 tests  ±0   2 184 ✔️ ±0   2m 37s ⏱️ -3s
       1 suites ±0          1 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 02f6f96. ± Comparison against base commit ea8a587.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #804 (02f6f96) into master (ea8a587) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #804      +/-   ##
==========================================
- Coverage   96.87%   96.84%   -0.04%     
==========================================
  Files          88       88              
  Lines        6025     6025              
==========================================
- Hits         5837     5835       -2     
- Misses        188      190       +2     
Impacted Files Coverage Δ
weldx/tags/core/geometry/spatial_data.py 95.00% <0.00%> (-5.00%) ⬇️
...gs/core/transformations/local_coordinate_system.py 97.14% <0.00%> (-2.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@CagtayFabry
Copy link
Member Author

please feel free to merge this if the tutorials run through without the warning now @marscher :)

@CagtayFabry
Copy link
Member Author

just checkend the RTD output, everything looks fine 👍

@CagtayFabry CagtayFabry merged commit 80c9695 into master Sep 22, 2022
@CagtayFabry CagtayFabry deleted the update-tutorial-weldx-file branch September 22, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation no-changelog-entry-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants