update environment & dependency versions to asdf 2.7 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev_asdf #83 +/- ##
=========================================
Coverage 99.40% 99.40%
=========================================
Files 59 59
Lines 2691 2691
=========================================
Hits 2675 2675
Misses 16 16
Continue to review full report at Codecov.
|
CagtayFabry
commented
Jul 24, 2020
| @@ -13,12 +13,12 @@ properties: | |||
| joint_design: | |||
| description: | | |||
| AWS 3.0, p. 19 : "Detailed Description of mating configuration of two components, sufficient information for shop preparation of the components." TODO CLASS | |||
| $ref: ../../core/iso_groove-1.0.0 | |||
| tag: "tag:weldx.bam.de:weldx/core/iso_groove-1.0.0" | |||
There was a problem hiding this comment.
for some reason using $ref here will fail oneOf validation in iso_groove-1.0.0 but no idea why (maybe cause of nested relative #definition refs in iso_groove-1.0.0 ?)
So try to use tag validation over $ref as much as possible I guess
vhirtham
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.