Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ruff 233, nbqa 1.6.1 #842

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Conversation

CagtayFabry
Copy link
Member

Changes

update ruff to 230 which has --force-exclude set by default

Not sure if this propagates to NBQA

@github-actions
Copy link

github-actions bot commented Jan 24, 2023

Test Results

2 184 tests  ±0   2 183 ✔️ ±0   2m 29s ⏱️ -10s
       1 suites ±0          1 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 99a5d0a. ± Comparison against base commit 17a5c1f.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #842 (99a5d0a) into master (17a5c1f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #842   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files          92       92           
  Lines        6071     6071           
=======================================
  Hits         5879     5879           
  Misses        192      192           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@marscher
Copy link
Contributor

nbqa has its own ruff command line.

@marscher marscher changed the title update ruff 230 update ruff 233, nbqa 1.6.1 Jan 25, 2023
@marscher marscher merged commit add5d82 into BAMWelDX:master Jan 25, 2023
@CagtayFabry
Copy link
Member Author

nbqa has its own ruff command line.

Are the NBAa releases tied to a specific ruff release or is that "up to date"?

@CagtayFabry CagtayFabry deleted the update_ruff_230 branch January 25, 2023 10:33
@marscher
Copy link
Contributor

As nbqa is just a wrapper for the underlying tools, I think the latest version of the demanded tool will be installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants