-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix XArray LCS join #861
Fix XArray LCS join #861
Conversation
pyproject.toml
Outdated
@@ -38,7 +38,7 @@ dependencies = [ | |||
"numpy >=1.20", | |||
"asdf >=2.8.2,!=2.14.0,!=2.14.1,!=2.14.2", | |||
"pandas >=1.0", | |||
"xarray >=0.19,<2022.09.0", | |||
"xarray >=2023.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we can also think of finding the XArray version which introduced Dataset.merge(join="override"), but I found it easier to just request at least a recent version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This XArray version dropped support for Python 3.8!
As we are at 3.11 now and 3.12 pending, we should do the same.
from the description of |
At least we have some test cases which produce non equal indices. Otherwise it would not fail with join="equal", right? |
I assume that's the case, but it would be good to check it properly |
I just ran the test now with xarray |
great, thank you |
Python 3.11 currently fails with
So we would need to release another version to fix this for Python 3.11, but I do not think this is urgent. |
I think I caught the bug though I am not completely sure what caused the change in xarray behavior (I think improved attribute propagation in xarray functions) I don't mind releasing 0.6.5 at this point, it's nice to be back on the xarray release cycle |
Codecov Report
@@ Coverage Diff @@
## master #861 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 95 95
Lines 6235 6238 +3
=======================================
+ Hits 6015 6018 +3
Misses 220 220
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Brilliant, then let's give a shot! |
Changes
Some new version of XArray changed the merge logic in a way being incompatible with our demands in LCS. Setting the join method of the merge to "override" seems to work (at least the tests are passing).
Related Issues
Properly fixes #810
Checks