Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for setting / handling environment variables #206

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

dschristianson
Copy link
Contributor

Correct documentation for setting environment variables
Correct handling of EPA_GEOSERVER_WFS_TIMEOUT_LIMIT value as a numeric

Fixes #205

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Test coverage >= 90%
  • Flake8 Tests
  • Mypy Tests
  • Other - manual tests setting various values for EPA_GEOSERVER_WFS_TIMEOUT_LIMIT

Test Configuration

  • Python Version: 3.10

PR Self Evaluation

  • My code follows the agreed upon best practices
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
    - [ ] I have added tests or modified existing tests that prove my fix is effective or that my feature works
  • Existing unit tests pass locally with my changes
    - [ ] Any dependent changes have been merged and published in the appropriate modules
  • I have performed a self-review of my own code

@dschristianson dschristianson marked this pull request as ready for review September 26, 2024 14:25
@dschristianson dschristianson merged commit 139725f into main Sep 26, 2024
3 checks passed
@dschristianson dschristianson deleted the issue-205 branch September 26, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect instructions to set environ variable, EPA timeout limit bug
1 participant