Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/attachment_pdf_merger #369

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Conversation

jungwire
Copy link
Contributor

@jungwire jungwire commented Jul 2, 2024

Negotiator pull request:

Description:

Adds Doc and Docx conversion for merged PDF download

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

  • I have performed a self review of my code
  • My code follows Google Java Code style
  • I have made my code as simple as possible
  • I have added unit tests and the code coverage has not decreased
  • I have updated the documentation in all relevant places

@jungwire jungwire requested a review from konradlang July 2, 2024 14:15
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 21 lines in your changes missing coverage. Please review.

Please upload report for BASE (canserv-poc@ac62c18). Learn more about missing BASE report.

Files Patch % Lines
...c/negotiator/service/AttachmentMergingService.java 0.00% 21 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             canserv-poc     #369   +/-   ##
==============================================
  Coverage               ?   79.81%           
  Complexity             ?     1233           
==============================================
  Files                  ?      162           
  Lines                  ?     3794           
  Branches               ?      208           
==============================================
  Hits                   ?     3028           
  Misses                 ?      619           
  Partials               ?      147           
Flag Coverage Δ
unit 79.81% <12.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@konradlang konradlang merged commit 06358b2 into canserv-poc Jul 3, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants