#109 localization For The Login Dialog #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remembered login from the cookie
(also introduces a new signature for "navigateTo" that takes the outright ID of the menu item)
update from master
saadnoor
previously approved these changes
Dec 15, 2021
| dialog!.getUsername().setLabel("Username") | ||
| dialog!.getUsername().setPlaceHolder("name@company.com") | ||
| dialog!.getUsername().setSuffix("user") | ||
| dialog!.getUsername().setLabel(I18n.getTranslation("Username")) |
There was a problem hiding this comment.
rename it as username, lets maintain consistency while naming.
i18n/webkit.properties
Outdated
| @@ -0,0 +1,24 @@ | |||
| # | |||
| #Tue Dec 14 17:43:53 CET 2021 | |||
| Keep-mesigned-in=Keep me signed in | |||
There was a problem hiding this comment.
K should be in small letter
saadnoor
previously approved these changes
Dec 16, 2021
| dialog!.getRememberMe().addStyle("loginWidgetCheckBoxLabel") | ||
| dialog!.getRememberMe().addStyle("loginWidgetCheckBoxInputWrapper") | ||
| dialog!.getRememberMe().addStyle("loginWidgetCheckBoxControl") | ||
| rem content! = |
There was a problem hiding this comment.
remove this incomplete line
| dialog!.getRememberMe().addStyle("loginWidgetCheckBoxControl") | ||
| rem content! = | ||
| content! = dialog!.getContent() | ||
| dialog!.setRememberMe(content!.addCheckBox(content!.getAvailableControlID(),0,0,0,0,I18n.getTranslation("keep-mesigned-in"))) |
saadnoor
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localization for the Login Dialog
#109