Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added functions for group managed service accounts and fine grained pw pol #533

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Conversation

jfmaes
Copy link

@jfmaes jfmaes commented Jan 9, 2022

@Hubbl3 new PR this time with the modified DomainSearcher code, added fine grained pw pol as well for lolz.
Potentially can add LAPS as well but would require more mods, source for LAPS toolkit can be found here:
https://github.com/leoloobeek/LAPSToolkit/blob/master/LAPSToolkit.ps1

feel free to reject or to modify the function to fit the empire current powerview

@Hubbl3
Copy link

Hubbl3 commented Jan 9, 2022

@jfmaes is this a Get-DomainSearcher function that you wrote?

I know that Harmjoy wrote a lot of the PowerView functions to be standalone and it looks like the main difference is that your new one has dependencies on other functions within PowerView, well and the argument format is different. I am not sure there is a neccessarily a problem with that but just curious on where the source came from.

we may also be able to overload the function to hold both defintiions so we don't break any other dependencies

@jfmaes
Copy link
Author

jfmaes commented Jan 9, 2022

@jfmaes is this a Get-DomainSearcher function that you wrote?

I know that Harmjoy wrote a lot of the PowerView functions to be standalone and it looks like the main difference is that your new one has dependencies on other functions within PowerView, well and the argument format is different. I am not sure there is a neccessarily a problem with that but just curious on where the source came from.

we may also be able to overload the function to hold both defintiions so we don't break any other dependencies

comes from the LAPSToolkit :)

@Cx01N
Copy link

Cx01N commented Jan 26, 2022

@jfmaes is there an advantage in converting Get-DomainSearcher from a function to a filter? I tested some use cases and couldn't find anything that broke.

@vinnybod vinnybod changed the base branch from master to dev February 15, 2022 02:26
@vinnybod vinnybod merged commit 7d3d931 into BC-SECURITY:dev Feb 15, 2022
vinnybod added a commit that referenced this pull request Feb 21, 2023
* add auto-merge functionality for private-main prs

* Update .github/workflows/prerelease-sponsor-kali-merge-private.yml

* add concurrency restriction

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants