Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGTM code review recommendations #146

Closed
prjemian opened this issue May 19, 2019 · 0 comments · Fixed by #147
Closed

LGTM code review recommendations #146

prjemian opened this issue May 19, 2019 · 0 comments · Fixed by #147
Assignees
@prjemian
Labels
enhancement
Milestone
1.1.6

Comments

@prjemian
Copy link
Contributor

see https://lgtm.com/projects/g/BCDA-APS/apstools/alerts/?mode=list
@prjemian prjemian added this to the milestone-2019-09 milestone May 19, 2019
@prjemian prjemian self-assigned this May 19, 2019
prjemian added a commit that referenced this issue May 19, 2019
@prjemian
MNT #146 modify unused variable
aad9252
@prjemian prjemian mentioned this issue May 19, 2019
Merged
prjemian added a commit that referenced this issue May 19, 2019
@prjemian
MNT #146 indentation
b9690d5
prjemian added a commit that referenced this issue May 19, 2019
@prjemian
MNT #146 reconsider super(grandparent, ...)
690db51
prjemian added a commit that referenced this issue May 20, 2019
@prjemian
MNT #146 remove unnecessary assignment
f48b02b
prjemian added a commit that referenced this issue May 20, 2019
@prjemian
MNT #146 clean up alerts
da14cab
prjemian added a commit that referenced this issue May 20, 2019
@prjemian
Merge pull request #147 from BCDA-APS/LGTM-review-146
5e3d188 
fixes #146
@prjemian prjemian modified the milestones: milestone-2019-09, 1.1.6 May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prjemian prjemian

Labels
enhancement
Projects
None yet
Milestone
1.1.6
Development

Successfully merging a pull request may close this issue.

MNT #146 modify unused variable BCDA-APS/apstools
1 participant
@prjemian