Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPEC writer: Add empty #O0 to the header & #P0 line to each scan #222

Closed
prjemian opened this issue Aug 15, 2019 · 1 comment · Fixed by #225
Closed

SPEC writer: Add empty #O0 to the header & #P0 line to each scan #222

prjemian opened this issue Aug 15, 2019 · 1 comment · Fixed by #225
Assignees
@prjemian
Labels
maintenance
Milestone
1.1.13

Comments

@prjemian
Copy link
Contributor

prjemian commented Aug 15, 2019 •
edited
Loading

Per aps-8id-dys/ipython-8idiuser#13 (comment), add empty #O0 to the header & #P0 line to each scan in the writer. Related to #201

These lines are not needed for any data analysis but will be added to satisfy the intake requirements of certain software that expects (and requires) that something be present. Particularly, the SpecR module for MatLab will fail if there is no P0 control line. An empty list of positioners is all that is needed to satisfy this reader.
@prjemian prjemian self-assigned this Aug 15, 2019
@prjemian prjemian added this to the 1.1.12 milestone Aug 15, 2019
prjemian added a commit that referenced this issue Aug 15, 2019
@prjemian
DOC #222 changes
265f902
prjemian added a commit that referenced this issue Aug 15, 2019
@prjemian
GIT #222 ignore log files
fb7a664
This was referenced Aug 15, 2019
Merged
Closed
@prjemian
Copy link
Contributor Author

The unit test in tests/test_filewriter.py will need to be changed once a new version of spec2nexus with prjemian/spec2nexus#196 is released.

prjemian added a commit that referenced this issue Aug 15, 2019
@prjemian
TST #222 test how it should be
399378a
prjemian added a commit that referenced this issue Aug 15, 2019
@prjemian
MNT #222 satisfy the test
987a979
prjemian added a commit that referenced this issue Aug 15, 2019
@prjemian
TST #222
d831424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prjemian prjemian

Labels
maintenance
Projects
None yet
Milestone
1.1.13
Development

Successfully merging a pull request may close this issue.

SPEC writer: add #O0 and #P0 lines to SPEC file BCDA-APS/apstools
1 participant
@prjemian