Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve Codacy code review issues #339

Closed
prjemian opened this issue Jul 6, 2020 · 2 comments
Closed

resolve Codacy code review issues #339

prjemian opened this issue Jul 6, 2020 · 2 comments
Assignees
@prjemian
Labels
maintenance
Milestone
1.3.0

Comments

@prjemian
Copy link
Contributor

prjemian commented Jul 6, 2020

see https://app.codacy.com/gh/BCDA-APS/apstools/issues/index?bid=18630888
@prjemian prjemian added this to the 1.3.0 milestone Jul 6, 2020
@prjemian prjemian self-assigned this Jul 6, 2020
prjemian added a commit that referenced this issue Jul 6, 2020
@prjemian
MNT #339 remove trailing whitespace
2f71902
prjemian added a commit that referenced this issue Jul 6, 2020
@prjemian
MNT #339 Codacy review
4e5c5c6
prjemian added a commit that referenced this issue Jul 6, 2020
@prjemian
MNT #339 Codacy
7c899f1
prjemian added a commit that referenced this issue Jul 6, 2020
@prjemian
MNT #339 Codacy
dc6172c
prjemian added a commit that referenced this issue Jul 6, 2020
@prjemian
MNT #339 Codacy
5e875b4
prjemian added a commit that referenced this issue Jul 6, 2020
@prjemian
MNT #339 Codacy
e28b67e
@prjemian
Copy link
Contributor Author

prjemian commented Jul 6, 2020 •
edited
Loading

Codacy dithers on some features such as whitespace before docstring of class. In this case here and here whether indentation before bullet items in a markdown list.

Go figure.

prjemian added a commit that referenced this issue Jul 6, 2020
@prjemian
MNT #339 Codacy
ae7f5fb
prjemian added a commit that referenced this issue Jul 6, 2020
@prjemian
MNT #339 Codacy
e11c6bb
@prjemian
Copy link
Contributor Author

prjemian commented Jul 6, 2020

Aha! Two spaces between the * and the content!

prjemian added a commit that referenced this issue Jul 6, 2020
@prjemian
MNT #339 Codacy
736e52a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prjemian prjemian

Labels
maintenance
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
1 participant
@prjemian